feat(Rating, InfoRating): new components #1196
Conversation
|
Accessibility report ℹ️ You can run this locally by executing |
|
Size stats
|
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit ab2afcf. |
There was a problem hiding this comment.
Ignore all changes related to icons. There is a another PR in which these changes are applied (#1197). I've updated them here because I needed some of the new icons.
Once the mentioned PR is merged, these changes will not be visible anymore here
marcoskolodny
added
blocked
|
|
||
| type InfoRatingProps = Omit<QuantitativeRatingProps, 'type' | 'valueLabels'> & { | ||
| value?: number; | ||
| withHalfValue?: boolean; |
There was a problem hiding this comment.
what does this mean? is this to be able to control the precision (by half star or whole star)? why isn't this always true for InfoRating (and remove the prop)? If someone doesn't want half star precision they can Math.round from outside
There was a problem hiding this comment.
This is intended by design:
|
Screenshot tests report ✔️ All passing |
# [16.1.0](v16.0.0...v16.1.0) (2024-09-27) ### Features * **BrandLoadingScreen:** improve lottie animations ([#1235](#1235)) ([e7dc87f](e7dc87f)), closes [/github.com/airbnb/lottie-web/issues/1184#issuecomment-411586909](https:/airbnb/lottie-web/issues/1184/issues/issuecomment-411586909) * **Form fields:** allow blocking copy/cut ([#1251](#1251)) ([8fd2838](8fd2838)) * **Form fields:** improve accesibility of errors ([#1246](#1246)) ([e35a99e](e35a99e)) * **PhoneNumberField:** Custom formatter support + lazy load libphonenumber on demand ([#1244](#1244)) ([2ee88e9](2ee88e9)) * **PosterCard, DisplayMediaCard:** allow using srcSet for backgroundImage ([#1253](#1253)) ([3b3d85f](3b3d85f)) * **Rating, InfoRating:** new components ([#1196](#1196)) ([02c91f6](02c91f6)) * **SearchField, TextField:** support inputMode prop ([#1249](#1249)) ([fe31eca](fe31eca)) * **Sheet:** lazy load sheet implementations ([#1250](#1250)) ([40fecdd](40fecdd))
|
🎉 This PR is included in version 16.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue: Link
📄 Note
Haptic feedback requires implementing it in radio button component and coordinating with native teams (it may require changes in the bridge). I consider this as a different task (implementing haptic feedback for all the controls), and it can be iterated in a different PR.
This PR requires a major release in Mistica. There are no breaking changes caused by the components themselves, but because we need new icons from mistica-design repo, and design team has introduced some breaking changes in their latest release. We can't merge this PR until this one gets merged: #1197