Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PhoneNumberField): Custom formatter support + lazy load libphonenumber on demand #1244

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

pladaria
Copy link
Member

@pladaria pladaria commented Sep 17, 2024

  • load libphonenumber on demand
  • allow custom formatter which allows to not use libphonenumber at all

Copy link

github-actions bot commented Sep 17, 2024

Size stats

master this branch diff
Total JS 12.2 MB 12.2 MB +1.34 kB
JS without icons 2.01 MB 2.01 MB +1.34 kB
Lib overhead 68.2 kB 68.2 kB 0 B
Lib overhead (gzip) 16.6 kB 16.6 kB 0 B

Copy link

github-actions bot commented Sep 17, 2024

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Copy link

github-actions bot commented Sep 17, 2024

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-1x686obw3-flows-projects-65bb050e.vercel.app

Built with commit cada2df.
This pull request is being automatically deployed with vercel-action

@pladaria pladaria changed the title feat(PhoneNumberField): Custom formatter support + async load libphonenumber on demand feat(PhoneNumberField): Custom formatter support + lazy load libphonenumber on demand Sep 17, 2024
src/phone-number-field.tsx Show resolved Hide resolved
@pladaria pladaria added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit 2ee88e9 Sep 19, 2024
11 checks passed
@pladaria pladaria deleted the pladaria/WEB-2029_async-libphonenumber branch September 19, 2024 10:51
tuentisre pushed a commit that referenced this pull request Sep 27, 2024
# [16.1.0](v16.0.0...v16.1.0) (2024-09-27)

### Features

* **BrandLoadingScreen:** improve lottie animations ([#1235](#1235)) ([e7dc87f](e7dc87f)), closes [/github.com/airbnb/lottie-web/issues/1184#issuecomment-411586909](https:/airbnb/lottie-web/issues/1184/issues/issuecomment-411586909)
* **Form fields:** allow blocking copy/cut ([#1251](#1251)) ([8fd2838](8fd2838))
* **Form fields:** improve accesibility of errors ([#1246](#1246)) ([e35a99e](e35a99e))
* **PhoneNumberField:** Custom formatter support + lazy load libphonenumber on demand ([#1244](#1244)) ([2ee88e9](2ee88e9))
* **PosterCard, DisplayMediaCard:** allow using srcSet for backgroundImage ([#1253](#1253)) ([3b3d85f](3b3d85f))
* **Rating, InfoRating:** new components ([#1196](#1196)) ([02c91f6](02c91f6))
* **SearchField, TextField:** support inputMode prop ([#1249](#1249)) ([fe31eca](fe31eca))
* **Sheet:** lazy load sheet implementations ([#1250](#1250)) ([40fecdd](40fecdd))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 16.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-merge-queue bot pushed a commit that referenced this pull request Oct 3, 2024
Reverts #1244 because several issues have been
detected

---------

Co-authored-by: Pedro Ladaria <[email protected]>
tuentisre pushed a commit that referenced this pull request Oct 3, 2024
## [16.1.1](v16.1.0...v16.1.1) (2024-10-03)

### Bug Fixes

* **PhoneNumberField:** Revert lazy load of libphonenumber ([#1258](#1258)) ([3d18271](3d18271)), closes [#1244](#1244)
* **Sheet:** avoid content from rendering on top of sticky title/buttons ([#1247](#1247)) ([21ce399](21ce399))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants