Fixed recordable creation bug, attributes are set before passing reco…

…rdable to processor (open-telemetry#189)
TuckTuckFloof · Jul 17, 2020 · 879c2bf · 879c2bf
1 parent 876875d
commit 879c2bf
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/sdk/src/trace/span.cc b/sdk/src/trace/span.cc
@@ -53,7 +53,6 @@ Span::Span(std::shared_ptr<Tracer> &&tracer,
  {
  return;
  }
- processor_->OnStart(*recordable_);
  recordable_->SetName(name);
 
  attributes.ForEachKeyValue([&](nostd::string_view key, common::AttributeValue value) noexcept {
@@ -63,6 +62,7 @@ Span::Span(std::shared_ptr<Tracer> &&tracer,
 
  recordable_->SetStartTime(NowOr(options.start_system_time));
  start_steady_time = NowOr(options.start_steady_time);
+ processor_->OnStart(*recordable_);
 }
 
 Span::~Span()