Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is SpanContext the same during the entire Span lifetime? #189

Closed
bogdandrutu opened this issue Jul 22, 2019 · 2 comments
Closed

Is SpanContext the same during the entire Span lifetime? #189

bogdandrutu opened this issue Jul 22, 2019 · 2 comments
Labels
area:sampling Related to trace sampling
Milestone
v0.3

Comments

@bogdandrutu
Copy link
Member

Some implementations need to change the sampling flag during the lifetime of a span.
@bogdandrutu bogdandrutu mentioned this issue Jul 22, 2019
Merged
@iredelmeier iredelmeier added the area:sampling Related to trace sampling label Jul 30, 2019
@SergeyKanzhelev
Copy link
Member

And potentially add/modify tracestate collection

@SergeyKanzhelev SergeyKanzhelev added this to the Alpha v0.3 milestone Oct 3, 2019
@jmacd
Copy link
Contributor

jmacd commented Jan 22, 2020

This suggests to me that tracestate is not part of the SpanContext. We've changed the sampling API to return an immutable SpanContext once, so this is not needed.

@jmacd jmacd closed this as completed Jan 22, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@kmanghat
Fixed recordable creation bug, attributes are set before passing reco…
879c2bf 
…rdable to processor (open-telemetry#189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:sampling Related to trace sampling
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
4 participants
@bogdandrutu @iredelmeier @jmacd @SergeyKanzhelev