Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #1232 - Bug in turf-line-split #2460

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

hanneshdc
Copy link

@hanneshdc hanneshdc commented Jul 21, 2023

This PR fixes #1232.

The cause of the issue is the application of turf-square to feature bounding boxes, which sometimes incorrectly results in a smaller bounding box. While this is really a bug in turf-square, the application isn't needed here. Instead, we can remove the bbox calculation completely and allow geojson-rbush to calculate it for us instead.

From the template:

  • [ x ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ x ] Have read How To Contribute.
  • [ x ] Run npm test at the sub modules where changes have occurred.
  • [ x ] Run npm run lint to ensure code style at the turf module level.

Submitting a new TurfJS Module. (N/A)

@hanneshdc hanneshdc changed the title Fix Issue 1232 - Bug in turf-line-split Fix Issue #1232 - Bug in turf-line-split Jul 21, 2023
@mfedderly
Copy link
Collaborator

I'd like to merge this. Any chance you have time to clean up the merge conflicts first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lineSplit doesn't split correctly
2 participants