Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #1232 - Bug in turf-line-split #2460

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix Issue #1232 - Bug in turf-line-split #2460

wants to merge 8 commits into from

Commits on Jul 21, 2023

  1. Create failing test

    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e8c3152 View commit details
    Browse the repository at this point in the history

  2. Expect line segment to be split into three

    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    95e5066 View commit details
    Browse the repository at this point in the history

  3. Don't create square bbox's. This avoids a bug in turf-square, and als… 

    …o results in more efficient checks
    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    64cb21c View commit details
    Browse the repository at this point in the history

  4. Update tests

    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    88de242 View commit details
    Browse the repository at this point in the history

  5. Fix the test fixture filter

    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a364a5c View commit details
    Browse the repository at this point in the history

  6. Regenerated tests with update bboxs

    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4316aca View commit details
    Browse the repository at this point in the history

  7. Remove the bbox calculation completely. 

    This is handled by geojson-rbush already.
    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    82062d3 View commit details
    Browse the repository at this point in the history

  8. Lint

    Hannes Hille committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bfa79ea View commit details
    Browse the repository at this point in the history