Merge pull request #311 from soulseekah/fix-fsockopen-verify

WordPress · Oct 20, 2020 · 7626082 · 7626082
2 parents f89c2fa + 1007e5f
commit 7626082
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/library/Requests/Transport/fsockopen.php b/library/Requests/Transport/fsockopen.php
@@ -92,6 +92,8 @@ public function request($url, $headers = array(), $data = array(), $options = ar
  if (isset($options['verify'])) {
  if ($options['verify'] === false) {
  $context_options['verify_peer'] = false;
+ $context_options['verify_peer_name'] = false;
+ $verifyname = false;
  }
  elseif (is_string($options['verify'])) {
  $context_options['cafile'] = $options['verify'];

diff --git a/tests/Transport/Base.php b/tests/Transport/Base.php
@@ -567,6 +567,16 @@ public function testBadDomain() {
  $request = Requests::head('https://wrong.host.badssl.com/', array(), $this->getOptions());
  }
 
+ public function testBadDomainNoVerify() {
+ if ($this->skip_https) {
+ $this->markTestSkipped('SSL support is not available.');
+ return;
+ }
+
+ $response = Requests::head('https://wrong.host.badssl.com/', array(), $this->getOptions(array('verify' => false)));
+ $this->assertTrue($response->success);
+ }
+
  /**
  * Test that the transport supports Server Name Indication with HTTPS
  *