Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify => false does not work with fsockopen #311

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

soulseekah
Copy link
Contributor

See #310 fsockopen will fail

@soulseekah soulseekah changed the title Add verify => false tests verify => false does not work with fsockopen Feb 11, 2018
@codecov-io
Copy link

codecov-io commented Feb 11, 2018

Codecov Report

Merging #311 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #311      +/-   ##
============================================
+ Coverage     92.11%   92.23%   +0.12%     
  Complexity      760      760              
============================================
  Files            21       21              
  Lines          1762     1764       +2     
============================================
+ Hits           1623     1627       +4     
+ Misses          139      137       -2
Impacted Files Coverage Δ Complexity Δ
library/Requests/Transport/fsockopen.php 94.82% <100%> (+0.64%) 68 <0> (ø) ⬇️
library/Requests.php 75.25% <0%> (-0.34%) 118% <0%> (ø)
library/Requests/Transport/cURL.php 94.66% <0%> (+0.97%) 66% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3470169...1007e5f. Read the comment docs.

Copy link
Collaborator

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! Will fix the tests before merging though.

@Gerk
Copy link

Gerk commented Jun 7, 2018

Did this ever get pulled/addressed? I've run up against this issue and really don't want to have to move to another library as this one suits my needs very nicely (aside from this issue that is)

@jrfnl
Copy link
Member

jrfnl commented Sep 25, 2019

@soulseekah Thank you for this PR and sorry for the long wait.

This looks like a good change. Would you mind rebasing the PR so it becomes mergable ?
If you don't want to, don't know how or don't have the time, please let me know.

See WordPress#310 fsockopen will fail
As per the documentation setting verify to false suppresses all SSL
checks. Fixes WordPress#310
@soulseekah
Copy link
Contributor Author

Rebased. Thank you.

@schlessera schlessera merged commit 7626082 into WordPress:master Oct 20, 2020
@schlessera schlessera added this to the 1.7.1 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants