refactor: redo binary codec types to simplify #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR:
SerializedDict
->STObject
andSerializedList
->STArray
(to match rippled names)FieldInstance
to pull directly fromxrpl.core.binarycodec.types
, so that doesn't need to be edited every time a new type is addedThere are no feature changes here; this is just an internal refactor.
Context of Change
I was adding some new types to the binary codec and thought that needing to add them in 2 places was unnecessary. I fixed a few other things to make the binary codecs more analogous as well.
Type of Change
Test Plan
CI passes. Tests that test the internal objects were edited to use the new type names (the methods exposed externally have not changed at all).