feat: add support for current sidechain design #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
changed the title
1 task
mvadari
force-pushed
the
fix-binary-codec-types
branch
from
9aaba1b
to
38d7d7a
Compare
1 task
mvadari
force-pushed
the
remove-old-sidechains
branch
from
87456ce
to
1557fa0
Compare
|
Replaced with #417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds support for the latest version of the sidechain design. It also removes the helper methods that were used for the previous version, since those are no longer needed.
There are 6 new transaction types:
XChainCreateBridge(creates a new cross-chain bridge)XChainCreateClaimId(creates a new cross-chain claim ID)XChainCommit(locks/burns the funds on the source chain)XChainClaim(claims the transfer funds on the destination chain)XChainAddAttestation(submits an attestation from a witness server)Context of Change
sidechain prod release
Type of Change
Before / After
Test Plan
Tests were added for all the new features. CI passes.
Future Tasks