Fix broken test in connection.ts for node 18 and add node 18 testing (#…

…2183) * Change localhost to 127.0.0.1 * Add Node 18 testing
XRPLF · Jan 9, 2023 · 17f04b3 · 17f04b3
1 parent 8abcfe4
commit 17f04b3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -5,7 +5,7 @@ name: Node.js CI
 
 on:
  push:
- branches: [ main, 1.x ]
+ branches: [main, 1.x]
  pull_request:
  workflow_dispatch:
 
@@ -57,7 +57,7 @@ jobs:
 
  strategy:
  matrix:
- node-version: [12.x, 14.x, 16.x]
+ node-version: [12.x, 14.x, 16.x, 18.x]
 
  steps:
  - uses: actions/checkout@v3
@@ -98,15 +98,14 @@ jobs:
 
  strategy:
  matrix:
- node-version: [12.x, 14.x, 16.x]
+ node-version: [12.x, 14.x, 16.x, 18.x]
 
  services:
  rippled:
  image: natenichols/rippled-standalone:latest
  ports:
- - 6006:6006
- options:
- --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
+ - 6006:6006
+ options: --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
 
  steps:
  - uses: actions/checkout@v3
@@ -156,9 +155,8 @@ jobs:
  rippled:
  image: natenichols/rippled-standalone:latest
  ports:
- - 6006:6006
- options:
- --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
+ - 6006:6006
+ options: --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s
 
  steps:
  - uses: actions/checkout@v3

diff --git a/packages/xrpl/test/connection.test.ts b/packages/xrpl/test/connection.test.ts
@@ -136,7 +136,7 @@ describe('Connection', function () {
  createServer().then((server: net.Server) => {
  const port = (server.address() as net.AddressInfo).port
  const options = {
- proxy: `ws://localhost:${port}`,
+ proxy: `ws://127.0.0.1:${port}`,
  authorization: 'authorization',
  trustedCertificates: ['path/to/pem'],
  }