Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test in connection.ts for node 18 and add node 18 testing #2183

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

JST5000
Copy link
Contributor

@JST5000 JST5000 commented Jan 6, 2023

High Level Overview of Change

Connection.ts had a broken test with proxy when using node 18.

Context of Change

The error:

  1) Connection
       with proxy:
     Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/jacksonmills/Documents/xrpl-js-6/xrpl.js/packages/xrpl/test/connection.test.ts)
      at listOnTimeout (node:internal/timers:564:17)
      at processTimers (node:internal/timers:507:7)

Type of Change

  • Tests (You added tests for code that already exists, or your new feature included in this PR)

Before / After

Changed localhost to 127.0.0.1 following this workaround: node-fetch/node-fetch#1624

Test Plan

Run tests locally & get a code reviewer to try the same with Node 18

Turn on Node 18 CI

@JST5000 JST5000 changed the title Fix broken test in connection.ts for node 18 Fix broken test in connection.ts for node 18 and add node 18 testing Jan 6, 2023
@JST5000 JST5000 merged commit 17f04b3 into main Jan 9, 2023
@JST5000 JST5000 deleted the fix-node-18 branch January 9, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants