Fix broken test in connection.ts for node 18 and add node 18 testing #2183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Connection.ts had a broken test
with proxy
when using node 18.Context of Change
The error:
Type of Change
Before / After
Changed
localhost
to127.0.0.1
following this workaround: node-fetch/node-fetch#1624Test Plan
Run tests locally & get a code reviewer to try the same with Node 18
Turn on Node 18 CI