Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely rewrote the cutscene asset handler. Now instead of parsing the data from the original overlay into a C-like header file, it instead follows a two-stage process. This works by extracting it in
asset/
withmake extract_assets
, to then allow modders to modify the file and build it as a C-like header withmake build_assets
. This also aims to fix #1701 as the build process takes account of the two-stage process.I created a framework where each asset type should only make available the two methods
Extract
andBuild
. The entire transformation process should be isolated to not create cognitive overload like what we can find inbuild.go
. I would need to migrate all the existing asset types to properly use this new framework. The old code served well enough to understand how to build the entire infrastructure, but it needs to be migrated using the new pattern.Last, but not least, I renamed
config/assets.us.weapon.yaml
toconfig/assets.us.yaml
as it is now used by all the overlays