Modernize headers

[Xeeynamo]

Extract some commits out of #1701 and avoid the part that will lead to a build failure (fixed in #1738).

Now every header uses OVL_EXPORT.

[sozud]

Looks like zero sized array issues

D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(11,14): error C2133: 'spriteBanks': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]
D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(12,16): error C2133: 'cluts': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]
D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(13,18): error C2133: 'rooms_layers': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]
D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(14,17): error C2133: 'gfxBanks': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]

[sozud]

Seems good once it compiles

[Xeeynamo]

Looks like zero sized array issues

D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(11,14): error C2133: 'spriteBanks': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]
D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(12,16): error C2133: 'cluts': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]
D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(13,18): error C2133: 'rooms_layers': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]
D:\a\sotn-decomp\sotn-decomp\src\st\wrp\header.c(14,17): error C2133: 'gfxBanks': unknown size [D:\a\sotn-decomp\sotn-decomp\pc\core.vcxproj]

I cannot come up with any fix for that unfortunately. I am hitting another wall.

[Xeeynamo]

I cherry-picked the commit from #1754 and it is now green 🟢

[sozud]

I cannot come up with any fix for that unfortunately. I am hitting another wall.

Can the tool not detect the size of the arrays and emit a #define SPRITE_BANKS_SIZE to avoid these?

[Xeeynamo]

I cannot come up with any fix for that unfortunately. I am hitting another wall.

Can the tool not detect the size of the arrays and emit a #define SPRITE_BANKS_SIZE to avoid these?

For the sprite banks size alone it might work, even if it is not that scalable. We would need to do that too to spriteBanks, Cluts, rooms_layers. And we might have the same issue somewhere else. I feel we're playing a game catching up with these issues. MSDN recommends to add /c and remove /Za but that does not work. At the same time I do not want to stall or try circumnavigating certain issues that will prevent moddability just to please a compiler that we do not know when (and if) the flags are going to get fixed.

[sozud]

It looks like some of the CI steps are being skipped due to the conflicts?

[Xeeynamo]

It looks like some of the CI steps are being skipped due to the conflicts?

solved

[sozud]

Looks good, thanks for fixing the msvc issues