Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support -d, --directory #133

Closed
YamatoSecurity opened this issue Mar 9, 2024 · 2 comments · Fixed by #145
Closed

Support -d, --directory #133

YamatoSecurity opened this issue Mar 9, 2024 · 2 comments · Fixed by #145
Assignees
@hitenkoku
Labels
enhancement New feature or request
Milestone
v2.5.0

Comments

@YamatoSecurity
Copy link
Collaborator

Support -d, --directory to load multiple JSONL files. For example, when multiple JSONL files are returned from Velociraptor.
@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Mar 9, 2024
@YamatoSecurity YamatoSecurity added this to the v2.5.0 milestone Mar 9, 2024
@hitenkoku
Copy link
Collaborator

@YamatoSecurity I am aware that the timeline option specifies a single file and the directory option cannot be used with the timeline option.

If I make the timeline opution in CLIGEN, I will not be able to get the REQUIRED help I have been getting so far, is that a problem?

If that is the case, I think it would be better to make the timeline option directory-compatible, what do you think?

@YamatoSecurity
Copy link
Collaborator Author

@hitenkoku That is a good idea! Yes, let's make --timeline compatible with directories so that if a directory is specified it will recursively scan for *.jsonl files to load.

hitenkoku added a commit that referenced this issue Mar 23, 2024
@hitenkoku
feat: adjusted directory input in timeline option #133
ee7ab07
@hitenkoku hitenkoku mentioned this issue Mar 23, 2024
Merged
@hitenkoku hitenkoku linked a pull request Mar 23, 2024 that will close this issue
Corresponding timeline option for directory input #145
Merged
hitenkoku added a commit that referenced this issue Mar 23, 2024
@hitenkoku
test(testsubmodule): due to changed getTargetExtFileLists function ar…
82cd2c8 
…guments #133
hitenkoku added a commit that referenced this issue Mar 26, 2024
@hitenkoku
fix(general): fixed checkArgs quit condition #133
fc4bf60
hitenkoku added a commit that referenced this issue Mar 26, 2024
@hitenkoku
fix(general): modified to adapt directory path #133
1c02961
hitenkoku added a commit that referenced this issue Mar 28, 2024
@hitenkoku
fix: fixed overwrite result file when timeline option is directory #133
b816f9c
hitenkoku added a commit that referenced this issue Mar 28, 2024
@hitenkoku
fix: fixed bug split-csv-timeline caused by directory processing #133
2251ac0
hitenkoku added a commit that referenced this issue Mar 28, 2024
@hitenkoku
fix: fixed bug caused by selected wrong extension #133
1741ef5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Corresponding timeline option for directory input Yamato-Security/takajo
2 participants
@hitenkoku @YamatoSecurity