-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corresponding timeline
option for directory input
#145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku
When I tried specifying a directory in -t
option, file does not exist
was displayed, but maybe I'm using it incorrectly?🤔 (I think that changed it so that the directory can be specified in the -t
option instead of the -d
option.)
% pwd
/Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ls -la tl
total 688144
drwxr-xr-x 10 fukusuke staff 320 3 22 20:19 .
drwx------@ 24 fukusuke staff 768 3 23 22:30 ..
-rw-r--r-- 1 fukusuke staff 44025018 3 17 09:49 timeline--European-time.jsonl
-rw-r--r-- 1 fukusuke staff 43927488 3 17 09:50 timeline--ISO-8601.jsonl
-rw-r--r-- 1 fukusuke staff 44072814 3 17 09:50 timeline--RFC-2822.jsonl
-rw-r--r-- 1 fukusuke staff 44089744 3 17 09:50 timeline--RFC-3339.jsonl
-rw-r--r-- 1 fukusuke staff 44025018 3 17 09:51 timeline--US-military-time.jsonl
-rw-r--r-- 1 fukusuke staff 44122107 3 17 09:51 timeline--US-time.jsonl
-rw-r--r-- 1 fukusuke staff 44025018 3 17 09:51 timeline--UTC.jsonl
-rw-r--r-- 1 fukusuke staff 44025018 3 17 13:50 timeline.jsonl
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ./takajo automagic -q -t /Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl
The file '/Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl' does not exist. Please specify a valid file path.
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ./takajo automagic -q -t /Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl/
The file '/Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl/' does not exist. Please specify a valid file path.
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ./takajo automagic -q -t ./tl
The file './tl' does not exist. Please specify a valid file path.
Also, csv-timeline
seems to fail in Integration-Test, so could you please check it?🙏
https:/Yamato-Security/takajo/actions/runs/8402036417/job/23011009274#step:24:26
@hitenkoku
Therefore, I think it would be nice if we could specify the root path to
|
@fukusuket Sorry for late reply.
|
@hitenkoku
Also, could you please check the following error?🙏 |
I also checked in my Windows 11 environment! but it seems to be an error🤔
|
My confirmation was insufficient. I fixed in 1c02961. Would you check it?
|
@hitenkoku It seems that only the last JSONL analysis result remains in the CSV file.(because it is overwritten each time JSONL analysis is performed). I think we could solve the file overwriting issue if we control the directory for loop on the takajoCore.nim side🤔 takajo/src/takajopkg/takajoCore.nim Line 45 in 1c02961
|
I would appreciate it if you could check the above error as well🙏 |
Thanks for your review. |
I fixed following problem. Evidence is https:/Yamato-Security/takajo/actions/runs/8471381947. Would you check it?
|
@fukusuket I fixed #145 (comment) problem in b816f9c. Excuse me for repeatedly asking for a review, but could you please check? |
I get the following error:
|
@hitenkoku @YamatoSecurity |
I found the problem: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I updated the changelog and some wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for fix and checking!! LGTM!!🚀
What Changed
-d, --directory
#133timeline
option for directory input