Async tweaks #40
Merged
Async tweaks #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HttpClient` is fully thread-safe so does not need extra locking around it. This also renames `RequestLock` to `DelayLock`, to better describe what it is used for, and avoids during more work inside the lock than is strictly needed.
This is for the default value of `cancellationToken` parameters. It's longer, leading to more line breaks, but it also reads better.
Zastai
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the use of a client lock (not needed for
HttpClient), and ensures all internally-awaited tasks useConfigureAwait(false).