Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async tweaks #40

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Async tweaks #40

merged 3 commits into from
Jan 27, 2022

Commits on Jan 26, 2022

  1. Drop the use of a client lock 

    `HttpClient` is fully thread-safe so does not need extra locking around
it.

This also renames `RequestLock` to `DelayLock`, to better describe what
it is used for, and avoids during more work inside the lock than is
strictly needed.
    @Zastai
    Zastai committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    302ff2c View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Ensure use of ConfigureAwait(false)

    @Zastai
    Zastai committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    9029f0a View commit details
    Browse the repository at this point in the history

  2. Use default instead of new() 

    This is for the default value of `cancellationToken` parameters.
It's longer, leading to more line breaks, but it also reads better.
    @Zastai
    Zastai committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    85d50fc View commit details
    Browse the repository at this point in the history