Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library does not export include directory (needs bump of minimum CMake version to 3.0) #621

Open
MaxSavenkov opened this issue Mar 1, 2018 · 2 comments
Open

Library does not export include directory (needs bump of minimum CMake version to 3.0) #621

MaxSavenkov opened this issue Mar 1, 2018 · 2 comments

Comments

@MaxSavenkov
Copy link

If it is possible to bump minimum CMake version 3.0, then it would be useful to have Easylogging++ to export its include directory via using target_include_directories( easyloggingpp PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include ) instead of plain include_directories. This makes usage of the library easier (no need to specify include directory in end-user project), especially in cases where several sub-projects in the same tree need to use Easylogging++, and also is in line with the current best practices from CMake.
@abumq
Copy link
Owner

abumq commented Apr 1, 2018

Please feel free to create PR (from develop branch) i will accept it.

@MaxSavenkov
Copy link
Author

Done (#646)

@codecircuit codecircuit mentioned this issue Sep 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abumq @MaxSavenkov