Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export include directory when using Easylogging++ as a static library (Fix for #621) #646

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MaxSavenkov
Copy link

This makes the Easylogging++ more usable as a static library: now, the user can just add it as a sub-directory to his CMakeLists.txt and then user target_link_libraries( target_name easyloggingpp ) to both link the library to his project and add an include directory.

Also, I removed useless include_directories command which used a directory which (no longer?) exists.

The change only affects build system, and only for the case where build_static_lib flag is ON. It, however, requires a newer version of CMake (at least 2.8.11). I tested it with CMake 3.11, and it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant