improvements to notify popup handling #3029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out of NotifyView and into Notify itself
|
That is... beautiful? |
simplify to remove dependency on backbone cid fix bad stackIndex check move responsibility for re-enabling scrolling on body/removal of notify class on HTML element to notify.js so that it can wait until all are closed before doing so move code out of closeNotify/onCloseReady and into remove return early in onCloseReady to remove need for else block
|
I've stalled a bit on the rest of the work due to other priorities - but what I've done so far I think is still useful so I'd like to get it in anyway. |
|
closed temporarily to make way for #3169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(work in progress)