Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements to notify popup handling #3029

Closed
wants to merge 2 commits into from
Closed

improvements to notify popup handling #3029

wants to merge 2 commits into from

Commits on Feb 8, 2021

  1. move handlers for the global 'notify:cancel' & 'notify:close' events … 

    …out of NotifyView and into Notify itself
    @moloko
    moloko committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    adcc723 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. stack.find should be stack.findIndex 

    simplify to remove dependency on backbone cid
fix bad stackIndex check
move responsibility for re-enabling
scrolling on body/removal of notify
class on HTML element to notify.js
so that it can wait until all are closed
before doing so
move code out of closeNotify/onCloseReady
and into remove
return early in onCloseReady to remove need for else block
    @moloko
    moloko committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    f252299 View commit details
    Browse the repository at this point in the history