Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow direct playing from epg #74

Merged
merged 9 commits into from
Sep 18, 2019
Merged

Allow direct playing from epg #74

merged 9 commits into from
Sep 18, 2019

Conversation

michaelarnauts
Copy link
Collaborator

@michaelarnauts michaelarnauts commented Sep 17, 2019

This allows to play items directly from the EPG.

A few things I've noticed:

  • All items seems to get a playable_uuid when scraped from the html, even shows in the future. We can't know for sure if it is playable until we actually ask anvato for the stream. We get a 502 in _get_stream_info() when the stream doesn't exists yet.
  • The breadcrumb shows "Series / VTM GO / VTM GO / TV Guide", not sure why other sections don't do this.

Fixes #66
Fixes #72

@dagwieers
Copy link
Collaborator

You removed the setContent() that is why you get the "VTM GO" twice.

@michaelarnauts
Copy link
Collaborator Author

Hmm, I think it was the setContent that caused it to display twice.

@dagwieers
Copy link
Collaborator

This is it:

https:/pietje666/plugin.video.vrt.nu/blob/637e74ca634b718fda3637f66b04e20e87dbd6b1/resources/lib/kodiwrapper.py#L155-L166

        # Jump through hoops to get a stable breadcrumbs implementation
        category_label = ''
        if category:
            if not content:
                category_label = 'VRT NU / '
            if isinstance(category, int):
                category_label += self.localize(category)
            else:
                category_label += category
        elif not content:
            category_label = 'VRT NU'
        xbmcplugin.setPluginCategory(handle=self._handle, category=category_label)

@michaelarnauts
Copy link
Collaborator Author

Indeed, that will work. The issue is that Kodi adds the addon name when you do a setContent(), and the only way for the ListItems to display a small thumbnail, is to avoid doing a setContent().

@michaelarnauts michaelarnauts merged commit 7e846c6 into master Sep 18, 2019
@michaelarnauts michaelarnauts deleted the epg-direct-play branch September 18, 2019 08:14
@michaelarnauts michaelarnauts added the enhancement New feature or request label Oct 27, 2019
@dagwieers dagwieers added this to the v0.9.0 milestone Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPG timings don't account for timezone Find a way to link the EPG with a playable stream.
2 participants