Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opposite of a Ring [clean version of pr #1900] #1910

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jan 19, 2023

incorporates all the previous review comments on #1900, now invalidated
DONE/TODO:

  • intermediate algebraic structures/bundles 'below' IsRing, Ring
  • CancellativeCommutativeSemiring
  • Loop constructions

Since this PR is a 'clean' duplicate of the previous one, suggest that I try to complete it by finishing those intermediate structures before merging...
EDITED: all now done, barring the Loops, which I propose not to do with this PR.

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Jan 20, 2023

Hmmm... the CHANGELOG commits look funny. Let me look at those again after a good night's sleep.
EDITED that looks a lot better!

@jamesmckinna jamesmckinna mentioned this pull request Jan 26, 2023
1 task
@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Feb 20, 2023
@MatthewDaggitt MatthewDaggitt merged commit 7772dee into agda:master Feb 20, 2023
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this pull request Apr 17, 2023
plt-amy pushed a commit that referenced this pull request Jul 21, 2023
@andreasabel andreasabel mentioned this pull request Aug 27, 2023
MatthewDaggitt pushed a commit that referenced this pull request Oct 13, 2023
andreasabel pushed a commit that referenced this pull request Jul 10, 2024
@andreasabel andreasabel mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants