Get rid of redundant deps in System.Console.ANSI
#1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redundant deps : `Function.HalfAdjointEquivalence` `Data.Product.Function.Dependent.Propositional` replaced `Data.String` import with `Data.String.Base` in `Data.Nat.Show`
|
What about the import of (A genuine question for the library experts as well: how narrow should we make things on import?) |
|
Generally if you're in a module that focuses on definitions, then usually you want to be strict in your imports. If you're in a module that focuses on proofs then there's often not much to be gained by being stricter. The exception to the former is if your data types include proofs within them. |
|
Thanks @Saransh-cpp! |
plt-amy
pushed a commit
that referenced
this pull request
Jul 21, 2023
Merged
MatthewDaggitt
pushed a commit
that referenced
this pull request
Oct 13, 2023
andreasabel
pushed a commit
that referenced
this pull request
Jul 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1993
See #1993 (comment) and #1993 (comment)
Function.HalfAdjointEquivalence,Data.Product.Function.Dependent.PropositionalData.Stringimport withData.String.BaseinData.Nat.Show