Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated use of boolean in resp.enable_compression() #3322

Merged
merged 30 commits into from
Oct 16, 2018
Merged

Deprecated use of boolean in resp.enable_compression() #3322

merged 30 commits into from
Oct 16, 2018

Conversation

OisinA
Copy link
Contributor

@OisinA OisinA commented Oct 4, 2018

What do these changes do?

Gives a warning message about how using force as a boolean is deprecated.

Are there changes in behavior for the user?

They will receive a deprecation warning if they use force as a boolean.

Related issue number

3318

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Nick Timkovich and others added 5 commits September 16, 2018 18:02
If there isn't a .netrc file specified by an environment variable, it
can be confusing to see warnings about it. If NETRC isn't set, don't
warn. Only warn if: a) can't resolve HOME, b) can load, but can't parse
file, c) can't find file, d) file appears to exist at the default
location but is unreadable for some reason.
@asvetlov
Copy link
Member

asvetlov commented Oct 4, 2018

Please fix pep8 errors

@asvetlov
Copy link
Member

asvetlov commented Oct 5, 2018

still fails

pyup.io bot and others added 3 commits October 15, 2018 22:20
* Update async-timeout from 3.0.0 to 3.0.1

* Update cython from 0.28.5 to 0.29

* Update cython from 0.28.5 to 0.29

* Update cython from 0.28.5 to 0.29

* Update gunicorn from 19.8.1 to 19.9.0

* Update tox from 3.5.0 to 3.5.2
@asvetlov asvetlov merged commit e0bd30a into aio-libs:master Oct 16, 2018
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https:/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants