Fixed annotation for local_addr in TCPConnector.__init__ #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2019 14:51
asvetlov
approved these changes
May 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #3732 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 43 43
Lines 8554 8554
Branches 1377 1377
=======================================
Hits 8374 8374
Misses 75 75
Partials 105 105
Continue to review full report at Codecov.
|
This was referenced May 7, 2019
asvetlov
pushed a commit
that referenced
this pull request
May 7, 2019
(cherry picked from commit db80171) Co-authored-by: Mathieu Dugré <[email protected]>
asvetlov
added a commit
that referenced
this pull request
May 7, 2019
#3735) (cherry picked from commit db80171) Co-authored-by: Mathieu Dugré <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Change the type annotation from
Optional[str]=NonetoOptional[Tuple[str, int]]=None.Are there changes in behavior for the user?
No changes in behaviour for the user.
Related issue number
#3639
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.