Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Fixed annotation for local_addr in TCPConnector.__init__ (#3732) #3735

Merged
merged 1 commit into from
May 7, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented May 7, 2019

(cherry picked from commit db80171)

Co-authored-by: Mathieu Dugré [email protected]

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

(cherry picked from commit db80171)

Co-authored-by: Mathieu Dugré <[email protected]>
@asvetlov asvetlov requested a review from webknjaz as a code owner May 7, 2019 19:51
@asvetlov asvetlov merged commit c9a1086 into 3.5 May 7, 2019
@asvetlov asvetlov deleted the backport-db80171-3.5 branch May 7, 2019 21:56
@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants