Translucent fragments #69
Conversation
|
Actually, this PR won't work due to the addition of |
|
The logic on ScreenCoordinatorLayout to reverse the order of the drawing only works if it has exactly two children. If we do not detach the fragment, we'll end up with several children, and reversing the child draw order will not have the desired effect. I think the correct behavior is to reverse only the last two views |
|
@gusbicalho Yeah, reversing the last two views is probably correct for ScreenCoordinatorLayout. It has only been tested with the normal push/present case but could be modified to be more flexible. |
reverse only the last 2 children if willDetachCurrentScreen() is called
|
@gpeal Our last commit seems to solve the issue we were discussing. |
| reverseLastTwoChildren = false; | ||
| } | ||
| previousChildrenCount = drawingOps.size(); | ||
|
|
There was a problem hiding this comment.
@gpeal I guess we can keep track on children count on our side then ☝️
|
|
||
| private int previousBackStackEntryCount = 0; | ||
| private boolean reverseDrawing = false; | ||
| private List<DrawingOp> drawingOps = new ArrayList<>(); |
| super.removeView(view); | ||
| } | ||
|
|
||
| @Override | ||
| protected void dispatchDraw(Canvas canvas) { | ||
| super.dispatchDraw(canvas); | ||
|
|
||
| while (!drawingOps.isEmpty()) { | ||
| DrawingOp op = drawingOps.remove(drawingOps.size() - 1); | ||
| if (drawingOps.size() < previousChildrenCount) { |
There was a problem hiding this comment.
Can you add a comment here?
| } | ||
| previousChildrenCount = drawingOps.size(); | ||
|
|
||
| while (drawingOps.size() > 2) { |
There was a problem hiding this comment.
- Maybe we can make a
drawAndReleasehelper - Can this loop just be in the else case and loop until !empty? Seems like all it's doing is finishing this loop. Then make the if case include this loop plus what's currently there.
| } | ||
| previousChildrenCount = drawingOps.size(); | ||
|
|
||
| if (reverseLastTwoChildren) { |
There was a problem hiding this comment.
@Igor1201 Would this be even more readable if you did an explicit swap of the last 2 items in the if block then just loop through them all?
|
Thanks for your patience! By the way, do we have a schedule of when to tag releases/push to npm? |
Keep old screen below the new one to be presented if the new screen's
screenColoris translucent (to use like modals, for instance).Supersedes #60