Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for various modal presentation styles #75

Merged
merged 2 commits into from
Jun 1, 2017

Conversation

benkraus
Copy link
Contributor

This adds support for configuring the modal presentation style on a view presented modally in iOS. Full screen is the system default, which is cool, but not helpful when you want to show something as a form sheet in horizontally regular environments (iPhone plus sized in landscape, iPad), or as a popover.

This allows modalPresentationStyle to be passed as an option when presenting modally.

This adds support for configuring the modal presentation style on a view presented modally in iOS. Full screen is the system default, which is cool, but not helpful when you want to show something as a form sheet in horizontally regular environments (iPhone plus sized in landscape, iPad), or as a popover.

This allows `modalPresentationStyle` to be passed as an option when presenting modally.
@gusbicalho
Copy link

Would #69 solve your use case?

@benkraus
Copy link
Contributor Author

No. That only supports overCurrentContext in a very small use case. This allows for popovers, form sheets, etc.

@lelandrichardson
Copy link
Collaborator

@benkraus this is great, and I think we should have a way to solve this. We should potentially think about what the equivalent concepts on Android are and see if we can map them in the context of this PR.

@gpeal do you have any thoughts on this?

@benkraus
Copy link
Contributor Author

Yup, would totally love to see the Android side of this represented as well. The other chunk missing here is the preferredContentSize, which would allow setting a different size other than the default for when showing a view as a popover.

@gpeal
Copy link
Collaborator

gpeal commented Apr 19, 2017

@lelandrichardson @benkraus There isn't a direct analogy to these values on Android but reading through the docs, it looks like a fair number of them could be reproduced which is good. Seems like a useful feature if you're only supporting iOS though.

@benkraus benkraus merged commit 6654f4e into airbnb:master Jun 1, 2017
@benkraus benkraus deleted the modal-presentation-style branch June 1, 2017 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants