[ISSUE #8318] fix findAllConfigInfoForDumpAll sql args error (#8319)

* [ISSUE #8318] fix findAllConfigInfoForDumpAll sql args error Close #8318 * [ISSUE #8318] remove the unnecessary arg Close #8318
alibaba · May 13, 2022 · eff327d · eff327d
1 parent c68956b
commit eff327d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...ba/nacos/config/server/service/repository/embedded/EmbeddedStoragePersistServiceImpl.java b/...ba/nacos/config/server/service/repository/embedded/EmbeddedStoragePersistServiceImpl.java
@@ -1399,7 +1399,7 @@ public Page<ConfigInfoWrapper> findAllConfigInfoForDumpAll(final int pageNo, fin
 
  PaginationHelper<ConfigInfoWrapper> helper = createPaginationHelper();
 
- return helper.fetchPageLimit(sqlCountRows, sqlFetchRows, EMPTY_ARRAY, pageNo, pageSize,
+ return helper.fetchPageLimit(sqlCountRows, sqlFetchRows, new Object[] {(pageNo - 1) * pageSize, pageSize}, pageNo, pageSize,
  CONFIG_INFO_WRAPPER_ROW_MAPPER);
 
  }

diff --git a/...aba/nacos/config/server/service/repository/extrnal/ExternalStoragePersistServiceImpl.java b/...aba/nacos/config/server/service/repository/extrnal/ExternalStoragePersistServiceImpl.java
@@ -1435,13 +1435,11 @@ public Page<ConfigInfoWrapper> findAllConfigInfoForDumpAll(final int pageNo, fin
  + " g, config_info t WHERE g.id = t.id ";
  PaginationHelper<ConfigInfoWrapper> helper = createPaginationHelper();
 
- List<String> params = new ArrayList<String>();
-
  try {
- return helper.fetchPageLimit(sqlCountRows, sqlFetchRows, params.toArray(), pageNo, pageSize,
+ return helper.fetchPageLimit(sqlCountRows, sqlFetchRows, new Object[] {(pageNo - 1) * pageSize, pageSize}, pageNo, pageSize,
  CONFIG_INFO_WRAPPER_ROW_MAPPER);
  } catch (CannotGetJdbcConnectionException e) {
- LogUtil.FATAL_LOG.error("[db-error] " + e.toString(), e);
+ LogUtil.FATAL_LOG.error("[db-error]", e);
  throw e;
  }
  }