-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nacos-config findAllConfigInfoForDumpAll method bug #8318
Labels
Comments
I'm going to test it at once. |
onewe
added a commit
to onewe/nacos
that referenced
this issue
May 9, 2022
5 tasks
onewe
added a commit
to onewe/nacos
that referenced
this issue
May 9, 2022
KomachiSion
pushed a commit
that referenced
this issue
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In there have sql parameters bug.
ExternalStoragePersistServiceImpl#findAllConfigInfoForDumpAll
EmbeddedStoragePersistServiceImpl#findAllConfigInfoForDumpAll
Expected behavior
return Page Object.
Acutally behavior
SQL Error
Desktop (please complete the following information):
Resolvent
Maybe
ExternalStoragePersistServiceImpl#findAllConfigInfoForDumpAll
new Object[] {(pageNo - 1) * pageSize, pageSize} instead of params.toArray()
EmbeddedStoragePersistServiceImpl#findAllConfigInfoForDumpAll
new Object[] {(pageNo - 1) * pageSize, pageSize} instead of EMPTY_ARRAY
Thanks.
The text was updated successfully, but these errors were encountered: