Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

still get the instance after register twice and deregister #1733

Closed
EZLippi opened this issue Aug 20, 2019 · 0 comments · Fixed by #1736
Closed

still get the instance after register twice and deregister #1733

EZLippi opened this issue Aug 20, 2019 · 0 comments · Fixed by #1736
Labels
contribution welcome kind/bug Category issues or prs related to bug.

Comments

@EZLippi
Copy link
Contributor

EZLippi commented Aug 20, 2019 •
edited
Loading

Issue Description

i use namingService to register a instance, somehow i register a same instance twice, after i degister this instance, this instance is still in nacos
Type: bug report

Describe what happened (or what feature you want)

when i debug the program, I found that after i degister this instance, i can see the beatTask is removed from dom2Beat map, but i found there is still a beatTask running to send beatInfo to nacos server, as i see, every time register a instance will cause a new BeatInfo created, and this new BeatInfo will override the old one in dom2beat map, but the old one is not cancelled, so when i deregister this instance, the old beatTask still send beatInfo to nacos server,this will cause register again.

image

image

Describe what you expected to happen

when add beatInfo , we should consider if there is already exist one, and cancel it
@nkorange nkorange added contribution welcome kind/bug Category issues or prs related to bug. labels Aug 21, 2019
EZLippi added a commit to EZLippi/nacos that referenced this issue Aug 21, 2019
@EZLippi
fix: fix alibaba#1733
210f77e
@EZLippi EZLippi mentioned this issue Aug 21, 2019
Merged
1 task
nkorange added a commit that referenced this issue Sep 6, 2019
@nkorange
Merge pull request #1736 from EZLippi/develop
04af15e 
ISSUE #1733
@nacos-bot nacos-bot mentioned this issue Sep 6, 2019
Closed
xingguangsixian added a commit to xingguangsixian/nacos that referenced this issue Dec 7, 2019
@xingguangsixian
同步alibaba develop到自己的develop (#1)
dafcb7c 
* fix: closes alibaba#1569

* fix bug

* build main

* alibaba#1529
distro 使用本地时间记录心跳

* Fix alibaba#1591

* Add unit tests for common.GroupKey and utils.MD5

Fully-qualified classname
com.alibaba.nacos.client.config.common.GroupKey
com.alibaba.nacos.client.config.utils.MD5

These tests were written using Diffblue Cover.

* Fix alibaba#1591

* feat: support change password

* upgrade the fastjson version

* Fix namespace vulnerability

* 修复alibaba#1583

* no message

* 编译 main.*

* no message

* fix build

* fix FE

* 后端支持

* npm build

* fix CI

* 没有过滤条件直接返回原始Service列表

* add refresh memory

* remove unness const

* no message

* clear code

* build console

* revert error code

* Remove unnecessary code

* Delete the code that caused the list multi-element

* fix bug

* Unified constant use

* reverse `Service Name` and `Group Name`

* Fix bug

* Update version to 1.1.2-SNAPSHOT

* fix: font privatization

* Subject to the actual startup context path

* if not set the context path with the WebServerInitializedEvent then real '/' is context path

* RunningConfig support get from spring.properties configuration file

* Update version to 1.1.2

* Update version to 1.1.3

* Add unit tests for com.alibaba.nacos.config.server.utils.GroupKey

These tests were written using Diffblue Cover

* Use dynamic server version

* 1. Optimize log printing
2. Improve the robustness and readability of your code

* support datum is null case

* repair httpGetLarge#httpGetLarge will call entity.getContentType().getElements() the contentType is NPE

* Normalize http response entity with ResponseEntity by spring

* feat:

* cluster conf support multi instance inline seperator with ','

* add comma division with some case to use

* add comma division with some case to use

* add comma division with some case to use

* resolve conflict

* fix: fix alibaba#1733

* 页面修复

* use API to create param

* use API to create param

* [ISSUE] alibaba#1671 Unified request header "Client-Version"

* [ISSUE] alibaba#1671 Unified request header "Client-Version"

* 🐛 remove server.contextPath

* Update service description error in Open API Guide

* fix: fix alibaba#1665

* fix alibaba#1764.

* Compatible with older versions

* [Issue] alibaba#1769 Solve the bug of the clone configuration function

* Fix alibaba#1764

* [Issue] alibaba#1769 Solve the bug of the clone configuration function

* [Issue] alibaba#1769 Solve the bug of the clone configuration function

* fix: closes alibaba#1759

* fixed(cluster): fixed raft cluster state

* chore(cluster): delete no used note

* alibaba#1507 close server from current dir

* repair speel error and add debug log

* Fix alibaba#1621

* fix alibaba#1609

* fix alibaba#1609

* Make error information more specifically

* feature(triggerFlag): add triggerFlag for service

* feture(triggerFlag): add frontend show triggerFlag

* style: Modifiers should be declared in the correct order;Map init 设置大小 避免扩容；

* style: Modifiers should be declared in the correct order;Map init 设置大小 避免扩容；

* refactor: 局部变量是线程安全的；
          urlPattern改成static final；
          GroupKey重构

* improve(triggerFlag): add pre check for triggerFlag

* refactor: IO改成try resource。instanceList循环直接改成addAll

* chore(triggerFlag): adjust some details

* improve(instanceHealth): add update logic

* feat:

* Avoiding conflicted for creating directory.

* improve(triggerFlag): adjust triggerFlag calculation chance

* clean controllers code

* chore(reiggerFlag): delete unused function

* merge

* improve(triggerFlag): improve instance health flag

* Add synchronized when add/remove instance

* Update jackson version, see https://nvd.nist.gov/vuln/detail/CVE-2019-16335

* Fix alibaba#1874

* alibaba#1873, set default server expire timeout to 10 seconds and configurable.

* fix bug alibaba#1775

fix bug alibaba#1775

* build fe

* Clean up redundant StringUtils

* bug fix 1841

bug fix alibaba#1841

* fix alibaba#1916

* Bump netty-all from 4.0.42.Final to 4.1.42.Final

Bumps [netty-all](https:/netty/netty) from 4.0.42.Final to 4.1.42.Final.
- [Release notes](https:/netty/netty/releases)
- [Commits](netty/netty@netty-4.0.42.Final...netty-4.1.42.Final)

Signed-off-by: dependabot[bot] <[email protected]>

* alibaba#1409 Introduce MCP server

* alibaba#1409 gRPC server tuned OK.

* alibaba#1409 Update from Nacos

* alibaba#1409 Fix PMD

* Fix alibaba#1906

* fix the getting subscribers error

* Support unique instance index for each registered server

Signed-off-by: dizhe <[email protected]>

* 创建字符串不需要带入双引号，否则调用时会报Error:Unable access jarfile

* Support snowflake instance id generator

Signed-off-by: Vettal Wu <[email protected]>

* Fix test case error.

* clean code

* fix the CI errors

* remove the useless code that make ci errors

* Fix findbugs

* Add switch to turn on/off MCP server

* Update version to 1.1.4

* issues:调用修改实例接口,未传的参数值会被清空
alibaba#1957

* Change MCP service port to 8848

* Fix add metadata method NPE.

* Fix PMD

* fix alibaba#1947

* alibaba#1947 add test cases.

* issues:调用修改实例接口,未传的参数值会被清空
alibaba#1957

* issues:调用修改实例接口,未传的参数值会被清空
alibaba#1957

* [alibaba#2006] change to throw NacosException to make client handle the right Exception case

* make RequestVote RPC handler thread-safe

* Modify the string splicing method of getgroupedname()

* Remove debug option in startup script

* fix alibaba#2000

* alibaba#2018 Close inpuststream instead of connection.

* fix alibaba#1842

* fix alibaba#1858

* Fix client beat task executing when health check is disabled.

* refactor(client/config): increase the client's read timeout

In order to prevent the server from handling the delay of the client's long task, increase the
client's read timeout to avoid this problem.

* refactor(client/config): update timeout compute

* fix startup for java 11

* remvoe classpath

* Bump jackson-databind from 2.9.10 to 2.9.10.1

Bumps [jackson-databind](https:/FasterXML/jackson) from 2.9.10 to 2.9.10.1.
- [Release notes](https:/FasterXML/jackson/releases)
- [Commits](https:/FasterXML/jackson/commits)

Signed-off-by: dependabot[bot] <[email protected]>

* add toUpperCase

* optimize: the Boolean.parseBoolean(String s) method should be used when converting a String to a Boolean type

* fix 2025

* fix default value of database field

* add client context path config

* 修复 alibaba#2098

* add nacos console cors

* format code

* Update version to 1.2.0-SNAPSHOT

* Fix close connection exception.

* Fix alibaba#2123

* Fix alibaba#2020

* Fix alibaba#2123
@SkyXj SkyXj mentioned this issue Jul 29, 2020
Closed
zrlw added a commit to zrlw/nacos that referenced this issue Aug 3, 2021
@zrlw
fix alibaba#1733 again
84b9494
This was referenced Aug 3, 2021
Closed
Closed
zrlw added a commit to zrlw/nacos that referenced this issue Aug 4, 2021
@zrlw
fix alibaba#1733 again
6f98a0c
@zrlw zrlw mentioned this issue Aug 4, 2021
Merged
KomachiSion pushed a commit that referenced this issue Aug 5, 2021
@zrlw
fix #1733 again (#6557)
0e67a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE #1733 EZLippi/nacos
fix #1733 again zrlw/nacos
2 participants
@nkorange @EZLippi