Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1733 again for nacos 1.x #6557

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Aug 4, 2021

fix #1733 again for nacos 1.x to avoid creating beat task more than once by doing ConcurrentHashMap.put concurrently.
i met the issue again by using nacos sync:

  1. restart N instances of one sync task at the same time, it trigged sync event more than once,
  2. for each sync event, nacos sync called registerInstance concurrently,
  3. ConcurrentHashMap.put was called concurrently for the same instance.

@zrlw zrlw mentioned this pull request Aug 4, 2021
@KomachiSion KomachiSion merged commit 0e67a75 into alibaba:v1.x-develop Aug 5, 2021
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Aug 5, 2021
@KomachiSion KomachiSion added this to the 1.4.3 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants