-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependency Governance] Remove useless dependencies. #8472
Comments
…lete no use plugin versions. (alibaba#8472)
请先在提交PR前在issue中列举无用依赖, |
<dependency>
<groupId>net.jcip</groupId>
<artifactId>jcip-annotations</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<version>${truth.version}</version>
</dependency>
<!-- commons-logging nacos 项目自身无用,可由需要的三方依赖嵌套引入 -->
<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>${commons-logging.version}</version>
</dependency>
<!-- commons-dbcp 无用,用的是 HikariCP -->
<dependency>
<groupId>commons-dbcp</groupId>
<artifactId>commons-dbcp</artifactId>
<version>${commons-dbcp.version}</version>
</dependency>
<!-- commons-logging nacos 项目自身无用 -->
<dependency>
<groupId>commons-cli</groupId>
<artifactId>commons-cli</artifactId>
<version>${commons-cli.version}</version>
</dependency>
<!-- for aop -->
<dependency>
<groupId>org.aspectj</groupId>
<artifactId>aspectjrt</artifactId>
</dependency>
<dependency>
<groupId>cglib</groupId>
<artifactId>cglib-nodep</artifactId>
</dependency>
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-jasper</artifactId>
<version>${tomcat-embed-jasper.version}</version>
</dependency> |
这个应该可以删,可能是以前有引入过ThreadSafe或者NotThreadSafe, 移除掉编译不报错就行。
可以删, 以前用的dbcp,1.3以后换成hikari了
应该可以删, 测试框架应该是Junit4
可以删
可以删
这个不确定,可以再讨论下
这个不能删,api,common,client没有依赖spring,还需要依赖 |
commons-cli 确实没有被使用,commons-logging 会被其他用到的地方嵌套依赖进来,nacos 获取日志都是 Slf4j 门面 api。
这个晚点我回滚下,会和 netty 依赖那个提交冲突 pom.xml,所以等那个 PR 合并了我再 rebase 同时回滚 hamcrest 的变动。 |
那 |
…ns.logging.Log` with `org.slf4j.Logger`. (alibaba#8472)
…ns.logging.Log` with `org.slf4j.Logger`. (alibaba#8472)
Is your feature request related to a problem? Please describe.
Too many useless dependencies, too many and confusing.
太多无用依赖,多且让人费解。
Describe the solution you'd like
Dependency Governance, remove useless dependencies.
依赖治理,去除无用依赖。
Describe alternatives you've considered
Perhaps many of the dependencies were initially added, and after optimization and upgrading, useless dependencies were not removed.
或许很多是初期加入的依赖,然后经过优化升级后,无用的依赖就没有被去除。
Additional context
mvn clean install -Dmaven.test.skip=true -P release-nacos
Make sure there are no compile errors.
务必已保障没有编译错误。
The text was updated successfully, but these errors were encountered: