Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8472]: Dependency Governance, Remove useless dependencies. (#8472) #8473

Merged

Conversation

CherishCai
Copy link
Contributor

@CherishCai CherishCai commented May 28, 2022

issue #8472

What is the purpose of the change

Dependency Governance, Remove useless dependencies.

Brief changelog

XX

Verifying this change

mvn clean install -Dmaven.test.skip=true -P release-nacos
Make sure there are no compile errors.
务必已保障没有编译错误。

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

pom.xml Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #8473 (241c442) into develop (9273252) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8473      +/-   ##
=============================================
+ Coverage      41.26%   41.27%   +0.01%     
- Complexity      4396     4398       +2     
=============================================
  Files            876      876              
  Lines          31868    31868              
  Branches        3708     3708              
=============================================
+ Hits           13151    13155       +4     
  Misses         17400    17400              
+ Partials        1317     1313       -4     
Impacted Files Coverage Δ
...m/alibaba/nacos/naming/misc/HttpClientManager.java 69.04% <0.00%> (-14.29%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 55.84% <0.00%> (+1.29%) ⬆️
...de/doublewrite/delay/DoubleWriteEventListener.java 70.37% <0.00%> (+3.70%) ⬆️
.../alibaba/nacos/common/notify/DefaultPublisher.java 72.61% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9273252...241c442. Read the comment docs.

config/pom.xml Show resolved Hide resolved
KomachiSion
KomachiSion previously approved these changes Jun 7, 2022
@KomachiSion
Copy link
Collaborator

There are some conflicts with others commit.

@CherishCai
Copy link
Contributor Author

There are some conflicts with others commit.

@KomachiSion pom.xm conflict resolved three times 😭😂

@KomachiSion KomachiSion merged commit 703925a into alibaba:develop Jun 13, 2022
@KomachiSion KomachiSion added the dependencies Pull requests that update a dependency file label Jun 13, 2022
@KomachiSion KomachiSion added this to the 2.1.1 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants