Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RpcClient新增系统参数类 #8936

Closed
stone-98 opened this issue Aug 10, 2022 · 4 comments
Closed

RpcClient新增系统参数类 #8936

stone-98 opened this issue Aug 10, 2022 · 4 comments

Comments

@stone-98
Copy link
Contributor

Is your feature request related to a problem? Please describe.
RpcClient新增系统参数类,从系统属性中获取与Rpc相关处理分离,在之前的基础上新增:

  • nacos.remote.grpc.executor.keep.alive.millis
  • nacos.remote.grpc.request.timeout.millis
  • nacos.remote.rpc.request.timeout.millis
  • nacos.remote.rpc.request.retry.times
  • nacos.remote.rpc.server.keep.alive.millis

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@wuchubuzai2018
Copy link
Contributor

我之前还想该这种类似的东西呢,可是没有人反馈,没想到被你抢先了, 关联一下我之前发的ISSUE吧:#8765

@KomachiSion
Copy link
Collaborator

我提一下我的想法:

  1. 确实需要可配置的内容;
  2. 我觉得可以复用社区的另一功能 [Enhance] getting arguments use an unified way in the client module #8622.
  3. 还需要整理一下之前已经提供出去的一些参数,一起统一下

可以整合到一个issue里,把方案都贴在那个issue里,然后讨论出最终结果后再动手写PR。

@stone-98
Copy link
Contributor Author

我之前还想该这种类似的东西呢,可是没有人反馈,没想到被你抢先了, 关联一下我之前发的ISSUE吧:#8765

我在群里和issue上看到蛮多相关参数需要这种动态配置。所以就提了。不过我这个可能不太适合。

@stone-98
Copy link
Contributor Author

我提一下我的想法:

  1. 确实需要可配置的内容;
  2. 我觉得可以复用社区的另一功能 [Enhance] getting arguments use an unified way in the client module #8622.
  3. 还需要整理一下之前已经提供出去的一些参数,一起统一下

可以整合到一个issue里,把方案都贴在那个issue里,然后讨论出最终结果后再动手写PR。

感谢回复,稍后我会将Nacos-Client端所有已经支持的参数以及需要新增的参数梳理一下。然后重新开一个issue。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants