Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] getting arguments use an unified way in the client module #8622

Closed
onewe opened this issue Jun 24, 2022 · 2 comments
Closed

[Enhance] getting arguments use an unified way in the client module #8622

onewe opened this issue Jun 24, 2022 · 2 comments
Assignees
@onewe
Labels
area/Client Related to Nacos Client SDK good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Milestone
2.2.0

Comments

@onewe
Copy link
Collaborator

onewe commented Jun 24, 2022 •
edited
Loading

Backgroud

背景

There are three ways of getting arguments in the client module now, from the properties、from the Jvm arguments and from the system environment. so it needs an unified way that get arguments.

现在总共有3种获取参数的方式在客户端模块中, 有从 properties中获取的、从Jvm参数获取的和从System环境变了中获取的. 所以需要一种统一获取参数的方式.

The reasons are as follows:

  • switch arguments getting order
  • better mock test

原因如下:

  • 提供切换参数读取顺序能力
  • 更方便的模拟测试

More detail see https://www.yuque.com/docs/share/e9fcd9a3-f3fb-496d-9b8b-bf4b88db4df0
@li-xiao-shuang
Copy link
Collaborator

链接好像失效了

@li-xiao-shuang li-xiao-shuang added kind/enhancement Category issues or prs related to enhancement. good first issue Good for newcomers labels Jun 27, 2022
onewe added a commit to onewe/nacos that referenced this issue Jun 29, 2022
@onewe
[ISSUES alibaba#8622] Add NacosEnvironment and add some unit tests
c9fed80
@onewe onewe mentioned this issue Jun 29, 2022
Closed
5 tasks
onewe added a commit to onewe/nacos that referenced this issue Jun 30, 2022
@onewe
[ISSUES alibaba#8622] remove magic number
6eee219
onewe added a commit to onewe/nacos that referenced this issue Jun 30, 2022
@onewe
[ISSUES alibaba#8622] add array length judgment
120b2ea
@onewe onewe mentioned this issue Jul 4, 2022
Merged
5 tasks
onewe added a commit to onewe/nacos that referenced this issue Jul 8, 2022
@onewe
[ISSUES alibaba#8622] Add NacosEnvironment and add some unit tests
2725bd2 
- remove magic number
- refactor all of them
- add some unit tests for env
- modify search rule and reformat
- fix search order
- fix p3c error
KomachiSion pushed a commit that referenced this issue Jul 11, 2022
@onewe
[ISSUES #8622] Add NacosEnvironment and add some unit tests (#8680)
704210e 
* [ISSUES #8622] Add NacosEnvironment and add some unit tests

- remove magic number
- refactor all of them
- add some unit tests for env
- modify search rule and reformat
- fix search order
- fix p3c error

* fix ci error

* add some type converters

- enhance search method
- default_setting.properties is renamed nacos_default_setting.properties

* the property key of system environment replace dot with underscore

* add some default values and enhance SystemEnvPropertySource

* add the copyright information
@KomachiSion KomachiSion added this to the 2.1.1 milestone Jul 19, 2022
@onewe onewe mentioned this issue Jul 22, 2022
Closed
onewe added a commit to onewe/nacos that referenced this issue Aug 11, 2022
@onewe
[ISSUE alibaba#8622] add the scope isolation strategy
1186028 
- add setProperty,addProperties and containsKey methods
- remove PropertySourceSearch
@onewe onewe mentioned this issue Aug 11, 2022
Closed
5 tasks
@KomachiSion KomachiSion mentioned this issue Aug 11, 2022
Closed
onewe added a commit to onewe/nacos that referenced this issue Aug 11, 2022
@onewe
[ISSUE alibaba#8622] add the scope isolation strategy
6316870 
- add setProperty,addProperties and containsKey methods
- remove PropertySourceSearch
@onewe onewe mentioned this issue Aug 11, 2022
Closed
5 tasks
onewe added a commit to onewe/nacos that referenced this issue Oct 19, 2022
@onewe
[ISSUE alibaba#8622] replace Properties with NacosClientProperties
9bdd489
onewe added a commit to onewe/nacos that referenced this issue Oct 20, 2022
@onewe
[ISSUE alibaba#8622] support logging read properties from NacosClient…
6332bf4 
…Properties

- add NacosClientPropertiesLookup for log4j2
- add NacosClientPropertyAction for logback
- add a new constructor method to adapt NacosClientProperties for NacosNamingMaintainService
- add a new constructor method to adapt NacosClientProperties for NacosNamingService
- add a new constructor method to adapt NacosClientProperties for NacosConfigService
onewe added a commit to onewe/nacos that referenced this issue Oct 20, 2022
@onewe
[ISSUE alibaba#8622] fix ci error
6fee6a0
onewe added a commit to onewe/nacos that referenced this issue Oct 20, 2022
@onewe
[ISSUE alibaba#8622] fix ci error
1c170e7
onewe added a commit to onewe/nacos that referenced this issue Oct 20, 2022
@onewe
[ISSUE alibaba#8622] fix ci error
e5b40ae
onewe added a commit to onewe/nacos that referenced this issue Oct 20, 2022
@onewe
[ISSUE alibaba#8622] change log level to DEBUG
f78bcd4
@onewe onewe mentioned this issue Oct 20, 2022
Closed
5 tasks
onewe added a commit to onewe/nacos that referenced this issue Oct 21, 2022
@onewe
[ISSUE alibaba#8622] enhance derivative logic of NacosClientProperties
bbfc723
@KomachiSion KomachiSion reopened this Oct 26, 2022
@KomachiSion KomachiSion modified the milestones: 2.1.1, 2.2.0 Oct 26, 2022
onewe added a commit to onewe/nacos that referenced this issue Nov 2, 2022
@onewe
[ISSUE alibaba#8622] sub pr of 9356 - auth module
4ba0468 
- Replace system.getProperties and system.getEnv with  NacosClientProperties
- remove address server controller IT

relate alibaba#9356
onewe added a commit to onewe/nacos that referenced this issue Nov 2, 2022
@onewe
[ISSUE alibaba#8622] sub pr of 9356 - logging module
4502231 
- Replace system.getProperties and system.getEnv with  NacosClientProperties
- log4j and logback support reading properties from NacosClientProperties

relate alibaba#9356
onewe added a commit to onewe/nacos that referenced this issue Nov 2, 2022
@onewe
[ISSUE alibaba#8622] rollback about app name
495fe86
onewe added a commit to onewe/nacos that referenced this issue Nov 2, 2022
@onewe
[ISSUE alibaba#8622] remove unused import
7fce0cc
onewe added a commit to onewe/nacos that referenced this issue Nov 2, 2022
@onewe
[ISSUE alibaba#8622] sub pr of 9356 - util module
3194bca 
- Replace system.getProperties and system.getEnv with NacosClientProperties

relate alibaba#9356
onewe added a commit to onewe/nacos that referenced this issue Nov 3, 2022
@onewe
[ISSUE alibaba#8622] sub pr of 9356 - config and naming module
51eb187 
- Replace system.getProperties and system.getEnv with NacosClientProperties

relate alibaba#9356
onewe added a commit to onewe/nacos that referenced this issue Nov 3, 2022
@onewe
[ISSUE alibaba#8622] retry ci
892ab04
@KomachiSion KomachiSion mentioned this issue Nov 3, 2022
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Nov 3, 2022
@onewe
[ISSUE #8622] sub pr of 9356 - auth module (#9447)
645cd4a 
* [ISSUE #8622] sub pr of 9356 - auth module

- Replace system.getProperties and system.getEnv with  NacosClientProperties
- remove address server controller IT

relate #9356

* [ISSUE #8622] rollback about app name

* [ISSUE #8622] remove unused import

* [ISSUE #8622] retry ci
KomachiSion pushed a commit that referenced this issue Nov 3, 2022
@onewe
[ISSUE #8622] sub pr of 9356 - util module (#9453)
bd2b026 
- Replace system.getProperties and system.getEnv with NacosClientProperties

relate #9356
onewe added a commit to onewe/nacos that referenced this issue Nov 3, 2022
@onewe
[ISSUE alibaba#8622] resolve conflict
14dc8f7
onewe added a commit to onewe/nacos that referenced this issue Nov 4, 2022
@onewe
[ISSUE alibaba#8622] add unit tests for logging
57a0990
onewe added a commit to onewe/nacos that referenced this issue Nov 4, 2022
@onewe
[ISSUE alibaba#8622] fix unit test error
f4f944e
KomachiSion pushed a commit that referenced this issue Nov 4, 2022
@onewe
[ISSUE #8622] sub pr of 9356 - logging module (#9450)
46e6318 
* [ISSUE #8622] sub pr of 9356 - logging module

- Replace system.getProperties and system.getEnv with  NacosClientProperties
- log4j and logback support reading properties from NacosClientProperties

relate #9356

* [ISSUE #8622] add unit tests for logging
KomachiSion pushed a commit that referenced this issue Nov 4, 2022
@onewe
[ISSUE #8622] sub pr of 9356 - config and naming module (#9455)
82c2dea 
* [ISSUE #8622] resolve conflict

* [ISSUE #8622] fix unit test error
@xishian
Copy link

xishian commented May 29, 2024

这个类跟用户侧有什么关系？为什么出现在Java SDK的文档里？

@shalk shalk mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onewe onewe

Labels
area/Client Related to Nacos Client SDK good first issue Good for newcomers kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@xishian @li-xiao-shuang @KomachiSion @onewe