Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8622] sub pr of 9356 - config and naming module #9455

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Nov 3, 2022

  • Replace system.getProperties and system.getEnv with NacosClientProperties

relate #9356

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

KomachiSion
KomachiSion previously approved these changes Nov 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9455 (f4f944e) into develop (0aeb2bd) will increase coverage by 0.02%.
The diff coverage is 96.61%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9455      +/-   ##
=============================================
+ Coverage      47.55%   47.58%   +0.02%     
+ Complexity      4564     4561       -3     
=============================================
  Files            852      852              
  Lines          28316    28321       +5     
  Branches        3193     3192       -1     
=============================================
+ Hits           13467    13477      +10     
+ Misses         13620    13617       -3     
+ Partials        1229     1227       -2     
Impacted Files Coverage Δ
...ient/naming/remote/gprc/NamingGrpcClientProxy.java 70.63% <ø> (ø)
...com/alibaba/nacos/client/utils/ValidatorUtils.java 90.00% <ø> (ø)
...ba/nacos/client/config/impl/ServerListManager.java 64.81% <75.00%> (+0.13%) ⬆️
...libaba/nacos/client/config/NacosConfigService.java 72.00% <100.00%> (+0.28%) ⬆️
...baba/nacos/client/config/http/ServerHttpAgent.java 18.84% <100.00%> (ø)
...om/alibaba/nacos/client/config/impl/CacheData.java 63.41% <100.00%> (ø)
...alibaba/nacos/client/config/impl/ClientWorker.java 55.40% <100.00%> (+4.63%) ⬆️
...acos/client/config/impl/ConfigTransportClient.java 86.11% <100.00%> (ø)
.../com/alibaba/nacos/client/config/impl/Limiter.java 66.66% <100.00%> (ø)
...s/client/config/impl/LocalConfigInfoProcessor.java 32.92% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aeb2bd...f4f944e. Read the comment docs.

@KomachiSion KomachiSion merged commit 82c2dea into alibaba:develop Nov 4, 2022
@onewe onewe deleted the issues/9356-4 branch November 4, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants