Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add transmitter info into ReverseBatchJournalRequestEntry #482

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: Add transmitter info into ReverseBatchJournalRequestEntry #482

merged 1 commit into from
Jul 8, 2024

Conversation

hiohiohio
Copy link
Contributor

Incompatible changes:

  • description is removed from CreateBatchJournalRequest and CreateReverseBatchJournalRequest

Context:

  • we missed transmitter info in ReverseBatchJournalRequestEntry
  • description for batch journal request should be in each entry instead of header

Changes:

  • add transmitter info into ReverseBatchJournalRequestEntry
  • add description into ReverseBatchJournalRequestEntry
  • remove description from CreateBatchJournalRequest and CreateReverseBatchJournalRequest

@hiohiohio hiohiohio requested a review from checksonhk July 8, 2024 03:40
@hiohiohio hiohiohio merged commit 9d53921 into master Jul 8, 2024
12 checks passed
@hiohiohio hiohiohio deleted the feat-add-transmitter-info-into-reverse-batch-journal-request-entry branch July 8, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@checksonhk checksonhk checksonhk approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@gnvk gnvk Awaiting requested review from gnvk

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

@said-saifi said-saifi Awaiting requested review from said-saifi

@matebudai matebudai Awaiting requested review from matebudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiohiohio @checksonhk