Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add transmitter info into ReverseBatchJournalRequestEntry #482

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: Add transmitter info into ReverseBatchJournalRequestEntry #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions alpaca/broker/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,12 +915,24 @@ class ReverseBatchJournalRequestEntry(NonEmptyRequest):
Entry in reverse batch journal request.

Attributes:
to_account (UUID): Account to fund in batch journal request.
amount (float): The cash amount in USD to fund by.
from_account (UUID): Account from fund in batch journal request.
amount (Union[str, float]): The cash amount in USD to fund by.
description (Optional[str]): Journal description.
transmitter_name (Optional[str]): For cash journals, travel rule related name info.
checksonhk marked this conversation as resolved.
Show resolved Hide resolved
transmitter_account_number (Optional[str]): For cash journals, travel rule account number info.
transmitter_address (Optional[str]): For cash journals, travel rule related address info.
transmitter_financial_institution (Optional[str]): For cash journals, travel rule related institution info.
transmitter_timestamp (Optional[str]): For cash journals, travel rule related timestamp info.
"""

from_account: UUID
amount: float
amount: Union[str, float]
description: Optional[str] = None
transmitter_name: Optional[str] = None
transmitter_account_number: Optional[str] = None
transmitter_address: Optional[str] = None
transmitter_financial_institution: Optional[str] = None
transmitter_timestamp: Optional[str] = None


class CreateBatchJournalRequest(NonEmptyRequest):
Expand All @@ -933,13 +945,11 @@ class CreateBatchJournalRequest(NonEmptyRequest):
Attributes:
entry_type (JournalEntryType): The type of journal transfer.
from_account (UUID): The originator of funds. Most likely is your Sweep Firm Account
description (Optional[str]): Journal description, gets returned in the response.
entries (List[BatchJournalRequestEntry]): List of journals to execute.
"""

entry_type: JournalEntryType
from_account: UUID
description: Optional[str] = None
entries: List[BatchJournalRequestEntry]


Expand All @@ -953,13 +963,11 @@ class CreateReverseBatchJournalRequest(NonEmptyRequest):
Attributes:
entry_type (JournalEntryType): The type of journal transfer.
to_account (UUID): The destination of funds. Most likely is your Sweep Firm Account
description (Optional[str]): Journal description, gets returned in the response.
entries (List[BatchJournalRequestEntry]): List of journals to execute.
"""

entry_type: JournalEntryType
to_account: UUID
description: Optional[str] = None
entries: List[ReverseBatchJournalRequestEntry]


Expand Down
Loading