Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of parser code from React source #223

Closed
alvarlagerlof opened this issue Aug 13, 2023 · 0 comments · Fixed by #646
Closed

Make use of parser code from React source #223

alvarlagerlof opened this issue Aug 13, 2023 · 0 comments · Fixed by #646

Comments

@alvarlagerlof
Copy link
Owner

alvarlagerlof commented Aug 13, 2023 •
edited
Loading

Problem

The parser in this codebase is currently reverse-engineered. It can handle some things, but not the full RSC format. When there are rows that it cannot handle, the UI is not capable to gracefully failing either.

Proposed solution

tbd, ideas:

  • Copy the react parser code, convert to TS, remove things that are not useful
  • Compile flow down to JS
  • Create a patch to apply every time it updates

facebook/react#26954
@alvarlagerlof alvarlagerlof mentioned this issue Jan 14, 2024
Merged
alvarlagerlof added a commit that referenced this issue Jan 28, 2024
@alvarlagerlof
Use ReactFightClient parser
3f06a9e 
This PR integrates code from  [ReactFlightClient](https:/facebook/react/blame/main/packages/react-client/src/ReactFlightClient.js) to make parsing more robust.

Fixes #223
Fixes #228
alvarlagerlof added a commit that referenced this issue Jan 28, 2024
@alvarlagerlof
Use ReactFightClient parser (#646)
611207b 
This PR integrates code from  [ReactFlightClient](https:/facebook/react/blame/main/packages/react-client/src/ReactFlightClient.js) to make parsing more robust.

Fixes #223
Fixes #228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ReactFightClient parser alvarlagerlof/rsc-parser
1 participant
@alvarlagerlof