Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore different way of rendering inline hints #228

Closed
alvarlagerlof opened this issue Aug 13, 2023 · 4 comments · Fixed by #646
Closed

Explore different way of rendering inline hints #228

alvarlagerlof opened this issue Aug 13, 2023 · 4 comments · Fixed by #646

Comments

@alvarlagerlof
Copy link
Owner

Problem

This is a little bit ugly:

image

Proposed solution

tbd
https://twitter.com/alvarlagerlof/status/1689197146283646977?s=20

<$L4
 |
 ------------------------------  This is a client ref [link]
or 
<$L4 --------------------------  This is a client ref [link
@flyingonionman
Copy link

flyingonionman commented Jan 7, 2024

in those Ascii examples, were you suggesting something formatted as such?
Capture

I don't think its going to create a confusion but having the link inside of the node makes it look like an attribute; I'm more pro it being outside of the brackets

@alvarlagerlof
Copy link
Owner Author

I'm working on a new parser using some of the react source (wip in #646), I have a new design for these there. It's inline because it made it easier to support references in various places, like in an object.

You can see the current design on the pic in this Tweet as well as a link to try it out. Let me know what you think!

@flyingonionman
Copy link

flyingonionman commented Jan 12, 2024

Oooo, looks good to me! Do you know where can I learn more about react-client related stuff? I've never seen it before.

Also hover previews would be nice for ref links

@alvarlagerlof
Copy link
Owner Author

Yeah hovering could be really nice. The hovercard would probably have to be limited in size, and not display the full information of the reference, because otherwise it would be too big.

alvarlagerlof added a commit that referenced this issue Jan 28, 2024
This PR integrates code from  [ReactFlightClient](https:/facebook/react/blame/main/packages/react-client/src/ReactFlightClient.js) to make parsing more robust.

Fixes #223
Fixes #228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants