-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore different way of rendering inline hints #228
Comments
I'm working on a new parser using some of the react source (wip in #646), I have a new design for these there. It's inline because it made it easier to support references in various places, like in an object. You can see the current design on the pic in this Tweet as well as a link to try it out. Let me know what you think! |
Oooo, looks good to me! Do you know where can I learn more about react-client related stuff? I've never seen it before. Also hover previews would be nice for ref links |
Yeah hovering could be really nice. The hovercard would probably have to be limited in size, and not display the full information of the reference, because otherwise it would be too big. |
This PR integrates code from [ReactFlightClient](https:/facebook/react/blame/main/packages/react-client/src/ReactFlightClient.js) to make parsing more robust. Fixes #223 Fixes #228
Problem
This is a little bit ugly:
Proposed solution
tbd
https://twitter.com/alvarlagerlof/status/1689197146283646977?s=20
The text was updated successfully, but these errors were encountered: