-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uiSref should allow transition to state with empty url #1362
Comments
@nateabele should we change this code to generate a https:/angular-ui/ui-router/blob/master/src/state.js#L1119 That way we'll return an empty string or hash and the ui-sref will be clickable ( https:/angular-ui/ui-router/blob/master/src/stateDirectives.js#L112 We'll still need the check for preventDefault, but only in html5mode, or actually when the generated href is "". See PR #1363 ... it's only generating an HREF if the top state has the |
Here's the updated plunk from #1319 |
An empty string still wouldn't work because of https:/angular/angular.js/blob/master/src/ng/directive/a.js#L42 — all Ah, just saw the PR. Looks good, but definitely needs test coverage. |
Closed via #1363 |
see comments in #1319
The text was updated successfully, but these errors were encountered: