fix(uiSref): nagivate to state when url is "" #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but this definitely needs unit tests. Let me know if you need help on it. |
fix($state.href): generate href for state with url: "" test(uiSref): add tests for html5Mode Made resolve values ignore any keys that we're actively trying to resolve, when they also exist in some parent state. Made ui-sref ignore a single preventDefault that comes from the <a> directive when there is no href (and the ui-sref is on an <a>) Closes #1363
christopherthielen
force-pushed
the
issue-1362
branch
from
2588c24
to
656b5aa
Compare
christopherthielen
added a commit
that referenced
this pull request
Sep 12, 2014
fix(uiSref): nagivate to state when url is ""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix($state.href): generate href for state with url: ""
Made resolve values ignore any keys that we're actively trying to resolve, when they also exist in some parent state.
Made ui-sref ignore a single preventDefault that comes from the directive when there is no href (and the ui-sref is on an )