fix(material/dialog): updates dialog max-height in landscape #29853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
crisbeto and
mmalerba
and removed request for
a team
andrewseguin
added
the
dev-app preview
|
Deployed dev-app for ea4ce5e to: https://ng-dev-previews-comp--pr-angular-components-29853-dev-c9ofr0p3.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
crisbeto
reviewed
Oct 10, 2024
Updates Angular Component Dialog component to have a max-height of 95vh which gives it a calculable height for its contents to adjust on smaller screens or in landscape mode so that the action buttons are able to be accessed by scrolling rather than the dialog window cutting them off. Fixes b/323588333
Updates previous fix to revert max-height back to inherit. Fixes b/323588333
essjay05
force-pushed
the
dialog-button-cutoff-fix-height
branch
from
c84b230
to
ea4ce5e
Compare
mmalerba
approved these changes
Oct 10, 2024
mmalerba
added
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Oct 10, 2024
* fix(material/dialog): updates dialog max-height in landscape Updates Angular Component Dialog component to have a max-height of 95vh which gives it a calculable height for its contents to adjust on smaller screens or in landscape mode so that the action buttons are able to be accessed by scrolling rather than the dialog window cutting them off. Fixes b/323588333 * refactor(material/dialog): reverted max-height to inherit Updates previous fix to revert max-height back to inherit. Fixes b/323588333 (cherry picked from commit da9cb71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Component Dialog component to have a max-height of 95vh which gives it a calculable height for its contents to adjust on smaller screens or in landscape mode so that the action buttons are able to be accessed by scrolling rather than the dialog window cutting them off.
Before screencast
After screencast
Fixes b/323588333