Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/dialog): updates dialog max-height in landscape #29853

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix(material/dialog): updates dialog max-height in landscape #29853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da8ba3a
fix(material/dialog): updates dialog max-height in landscape
essjay05 Oct 9, 2024
ea4ce5e
refactor(material/dialog): reverted max-height to inherit
essjay05 Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/material/dialog/dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ $mat-dialog-content-max-height: 65vh !default;
// don't expose this value as variable.
$mat-dialog-button-horizontal-margin: 8px !default;

// Dialog container max height. This has been given a default value so the
// flex-children can be calculated and not overflow on smaller screens.
// Fixes b/323588333
$mat-dialog-container-max-height: 95vh !default;

// Whether to emit fallback values for the structural styles. Previously MDC was emitting
// paddings in the static styles which meant that users would get them even if they didn't
// include the `dialog-base`. Eventually we should clean up the usages of this flag.
Expand Down
Loading