This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(select): fix set form to pristine if ng-model for multiple select…
- Loading branch information
1 parent
4d535e2
commit 19966a3
Showing
2 changed files
with
31 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19966a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone else have an issue with this? Basically it means if you dynamically add/remove these in an ngrepeat via a filter your form keeps getting marked as pristine. This fix seems like such a hack to fix an issue, like why isn't this fix tring to fix the reason its modifying the form to begin with? I'm going to be forking and looking into this, but if someone sees this and has any information that might be helpful let me know.
19966a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cstephe please open an issue with a reproduction and reference this commit.
19966a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Splaktar cool, done: #11490 reading up on PR process, will (attempt) submit soon.