fix(slider): allow tabindex overwrite

* add test for tabindex overwriting Fixes #5829. Closes #5830.
angular · Feb 4, 2016 · 47cfe44 · 47cfe44
1 parent 0873ace
commit 47cfe44
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/components/slider/slider.js b/src/components/slider/slider.js
@@ -74,10 +74,8 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
  // **********************************************************
 
  function compile (tElement, tAttrs) {
- tElement.attr({
- tabIndex: 0,
- role: 'slider'
- });
+ if (!tAttrs.tabindex) tElement.attr('tabindex', 0);
+ tElement.attr('role', 'slider');
 
  $mdAria.expect(tElement, 'aria-label');
 

diff --git a/src/components/slider/slider.spec.js b/src/components/slider/slider.spec.js
@@ -285,4 +285,14 @@ describe('md-slider', function() {
 
  });
 
+ it('should set a default tabindex', function() {
+ var slider = setup();
+ expect(slider.attr('tabindex')).toBe('0');
+ });
+
+ it('should not overwrite tabindex attribute', function() {
+ var slider = setup('tabindex="2"');
+ expect(slider.attr('tabindex')).toBe('2');
+ });
+
 });