Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(slider): allow tabindex overwrite #5830

Closed
wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

This commit allows the user to specify the tabindex of the slider element.

If there are anymore suggestions or other wishes, please tell me 👍

Fixes #5829

@ThomasBurleson ThomasBurleson added needs: review This PR is waiting on review from the team and removed needs: review This PR is waiting on review from the team labels Nov 24, 2015
@ThomasBurleson ThomasBurleson modified the milestone: 1.0-rc7 Nov 24, 2015
@danjarvis
Copy link
Contributor

Looks good. I would consider adding a small test for the fix:

it('should preserve tabindex', function() {
    var slider = setup('tabindex="2", ng-model="model"');
    expect(slider.attr('tabindex')).toBe(2);
}));

Fixes angular#5829

test(slider): add test for tabindex overwriting
@devversion
Copy link
Member Author

Done! Thanks @danjarvis for the suggestion.

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc7, 1.01 Nov 26, 2015
@EladBezalel EladBezalel added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Dec 31, 2015
@EladBezalel
Copy link
Member

LGTM

@ThomasBurleson ThomasBurleson modified the milestones: 1.0.1, 1.0.2 Jan 5, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.2, 1.0.5 Jan 30, 2016
ThomasBurleson pushed a commit that referenced this pull request Feb 4, 2016
* add test for tabindex overwriting

Fixes #5829. Closes #5830.
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
* add test for tabindex overwriting

Fixes angular#5829. Closes angular#5830
@devversion devversion deleted the fix/slider-tabindex branch April 19, 2016 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants